bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libalpm: process needed before group selection

Browse source 
When --needed is used, up to date packages are now filtered out
before showing the group select.

Fixes FS#22870.

Signed-off-by: morganamilo <morganamilo@gmail.com>
This commit is contained in:
morganamilo 2018-10-17 16:40:47 +01:00 • committed by Andrew Gregory
parent 8c9046e604
commit 02255fd97e
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/libalpm/sync.c
View file

@ -277,10 +277,21 @@ alpm_list_t SYMEXPORT *alpm_find_group_pkgs(alpm_list_t *dbs,
for(j = grp->packages; j; j = j->next) { for(j = grp->packages; j; j = j->next) {
alpm_pkg_t *pkg = j->data; alpm_pkg_t *pkg = j->data;
alpm_trans_t *trans = db->handle->trans;
if(alpm_pkg_find(ignorelist, pkg->name)) { if(alpm_pkg_find(ignorelist, pkg->name)) {
continue; continue;
} }
if(trans != NULL && trans->flags & ALPM_TRANS_FLAG_NEEDED) {
alpm_pkg_t *local = _alpm_db_get_pkgfromcache(db->handle->db_local, pkg->name);
if(local && _alpm_pkg_compare_versions(pkg, local) == 0) {
/* with the NEEDED flag, packages up to date are not reinstalled */
_alpm_log(db->handle, ALPM_LOG_WARNING, _("%s-%s is up to date -- skipping\n"),
local->name, local->version);
ignorelist = alpm_list_add(ignorelist, pkg);
continue;
}
}
if(alpm_pkg_should_ignore(db->handle, pkg)) { if(alpm_pkg_should_ignore(db->handle, pkg)) {
alpm_question_install_ignorepkg_t question = { alpm_question_install_ignorepkg_t question = {
.type = ALPM_QUESTION_INSTALL_IGNOREPKG, .type = ALPM_QUESTION_INSTALL_IGNOREPKG,