bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

util/pactree: correctly free the deps list in walk_deps()

Browse source 
If we are reversed, then we were correctly freeing both the list and the
contained data. However, we were leaking a list in the case of a
non-reversed traversal.

Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Dan McGee 2012-12-27 02:38:11 -06:00 • committed by Allan McRae
parent 60d2588192
commit 038b1815d0
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/util/pactree.c
View file

@ -472,7 +472,7 @@ static void walk_deps(alpm_list_t *dblist, alpm_pkg_t *pkg, tdepth *depth, int r
depth->next = &d; depth->next = &d;
/* last dep, cut off the limb here */ /* last dep, cut off the limb here */
if(last){ if(last){
if(depth->prev){ if(depth->prev) {
depth->prev->next = &d; depth->prev->next = &d;
d.prev = depth->prev; d.prev = depth->prev;
depth = &d; depth = &d;
@ -488,6 +488,8 @@ static void walk_deps(alpm_list_t *dblist, alpm_pkg_t *pkg, tdepth *depth, int r
if(rev) { if(rev) {
FREELIST(deps); FREELIST(deps);
} else {
alpm_list_free(deps);
} }
} }