bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libalpm: fix alpm_option_set_assumeinstalled

Browse source 
It looks like this function has never actually worked. The current list
is never set to NULL after being freed. So the new deps were just
appended to the already freed list, leading to a segfault.

Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
morganamilo 2020-01-23 06:38:35 +00:00 • committed by Allan McRae
parent 21af798604
commit 0a25548cd0
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/libalpm/handle.c
View file

@ -690,6 +690,7 @@ int SYMEXPORT alpm_option_set_assumeinstalled(alpm_handle_t *handle, alpm_list_t
if(handle->assumeinstalled) { if(handle->assumeinstalled) {
alpm_list_free_inner(handle->assumeinstalled, (alpm_list_fn_free)alpm_dep_free); alpm_list_free_inner(handle->assumeinstalled, (alpm_list_fn_free)alpm_dep_free);
alpm_list_free(handle->assumeinstalled); alpm_list_free(handle->assumeinstalled);
handle->assumeinstalled = NULL;
} }
while(deps) { while(deps) {
if(alpm_option_add_assumeinstalled(handle, deps->data) != 0) { if(alpm_option_add_assumeinstalled(handle, deps->data) != 0) {