bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libmakepkg: strip - add "safe_" prefix to stripping functions

Browse source 
Add a "safe_" prefix to strip_file() and strip_lto() to indicate that
these functions are taking extra steps to ensure permissions remain
unchanged.

Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Allan McRae 2024-12-24 17:10:30 +10:00
parent 5e2a763e4a
commit 0c136ecc8a
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scripts/libmakepkg/tidy/strip.sh.in
View file

@ -126,7 +126,7 @@ collect_debug_symbols() {
fi fi
} }
strip_file(){ safe_strip_file(){
local binary=$1; shift local binary=$1; shift
local tempfile=$(mktemp "$binary.XXXXXX") local tempfile=$(mktemp "$binary.XXXXXX")
if strip "$@" "$binary" -o "$tempfile"; then if strip "$@" "$binary" -o "$tempfile"; then
@ -135,7 +135,7 @@ strip_file(){
rm -f "$tempfile" rm -f "$tempfile"
} }
strip_lto() { safe_strip_lto() {
local binary=$1; local binary=$1;
local tempfile=$(mktemp "$binary.XXXXXX") local tempfile=$(mktemp "$binary.XXXXXX")
@ -193,10 +193,9 @@ tidy_strip() {
continue ;; continue ;;
esac esac
(( ! STATICOBJ )) && collect_debug_symbols "$binary" (( ! STATICOBJ )) && collect_debug_symbols "$binary"
strip_file "$binary" ${strip_flags} safe_strip_file "$binary" ${strip_flags}
(( STATICOBJ )) && strip_lto "$binary" (( STATICOBJ )) && safe_strip_lto "$binary"
done done
elif check_option "debug" "y"; then elif check_option "debug" "y"; then
msg2 "$(gettext "Copying source files needed for debug symbols...")" msg2 "$(gettext "Copying source files needed for debug symbols...")"