bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pacman-key: fix quotation on several variable assignments

Browse source 
This commit adds quotes to several variable assignments. Unquoted values
can cause problems on several occasions if the value is empty. It is
safer to have every assignment quoted.

Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
This commit is contained in:
Ivan Kanakarakis 2011-04-21 16:59:08 +03:00 • committed by Allan McRae
parent b300b991a7
commit 15ca6dca5c
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
scripts/pacman-key.sh.in
View file

@ -137,12 +137,12 @@ reload_keyring() {
if [[ -r "${REMOVED_KEYS}" ]]; then if [[ -r "${REMOVED_KEYS}" ]]; then
while read key; do while read key; do
local key_values name local key_values name
key_values=$(${GPG_PACMAN} --quiet --with-colons --list-key "${key}" | grep ^pub | cut -d: -f5,10 --output-delimiter=' ') key_values="$(${GPG_PACMAN} --quiet --with-colons --list-key "${key}" | grep ^pub | cut -d: -f5,10 --output-delimiter=' ')"
if [[ -n $key_values ]]; then if [[ -n $key_values ]]; then
# The first word is the key_id # The first word is the key_id
key_id=${key_values%% *} key_id="${key_values%% *}"
# the rest if the name of the owner # the rest if the name of the owner
name=${key_values#* } name="${key_values#* }"
if [[ -n ${key_id} ]]; then if [[ -n ${key_id} ]]; then
# Mark this key to be deleted # Mark this key to be deleted
removed_ids[$key_id]="$name" removed_ids[$key_id]="$name"
@ -152,12 +152,12 @@ reload_keyring() {
fi fi
# List of keys that must be kept installed, even if in the list of keys to be removed # List of keys that must be kept installed, even if in the list of keys to be removed
local HOLD_KEYS=$(get_from "$CONFIG" "HoldKeys") local HOLD_KEYS="$(get_from "$CONFIG" "HoldKeys")"
# Remove the keys that must be kept from the set of keys that should be removed # Remove the keys that must be kept from the set of keys that should be removed
if [[ -n ${HOLD_KEYS} ]]; then if [[ -n ${HOLD_KEYS} ]]; then
for key in ${HOLD_KEYS}; do for key in ${HOLD_KEYS}; do
key_id=$(${GPG_PACMAN} --quiet --with-colons --list-key "${key}" | grep ^pub | cut -d: -f5) key_id="$(${GPG_PACMAN} --quiet --with-colons --list-key "${key}" | grep ^pub | cut -d: -f5)"
if [[ -n "${removed_ids[$key_id]}" ]]; then if [[ -n "${removed_ids[$key_id]}" ]]; then
unset removed_ids[$key_id] unset removed_ids[$key_id]
fi fi
@ -168,7 +168,7 @@ reload_keyring() {
# be updated automatically. # be updated automatically.
if [[ -r "${ADDED_KEYS}" ]]; then if [[ -r "${ADDED_KEYS}" ]]; then
msg "$(gettext "Appending official keys...")" msg "$(gettext "Appending official keys...")"
local add_keys=$(${GPG_NOKEYRING} --keyring "${ADDED_KEYS}" --with-colons --list-keys | grep ^pub | cut -d: -f5) local add_keys="$(${GPG_NOKEYRING} --keyring "${ADDED_KEYS}" --with-colons --list-keys | grep ^pub | cut -d: -f5)"
for key_id in ${add_keys}; do for key_id in ${add_keys}; do
# There is no point in adding a key that will be deleted right after # There is no point in adding a key that will be deleted right after
if [[ -z "${removed_ids[$key_id]}" ]]; then if [[ -z "${removed_ids[$key_id]}" ]]; then
@ -179,7 +179,7 @@ reload_keyring() {
if [[ -r "${DEPRECATED_KEYS}" ]]; then if [[ -r "${DEPRECATED_KEYS}" ]]; then
msg "$(gettext "Appending deprecated keys...")" msg "$(gettext "Appending deprecated keys...")"
local add_keys=$(${GPG_NOKEYRING} --keyring "${DEPRECATED_KEYS}" --with-colons --list-keys | grep ^pub | cut -d: -f5) local add_keys="$(${GPG_NOKEYRING} --keyring "${DEPRECATED_KEYS}" --with-colons --list-keys | grep ^pub | cut -d: -f5)"
for key_id in ${add_keys}; do for key_id in ${add_keys}; do
# There is no point in adding a key that will be deleted right after # There is no point in adding a key that will be deleted right after
if [[ -z "${removed_ids[$key_id]}" ]]; then if [[ -z "${removed_ids[$key_id]}" ]]; then
@ -264,7 +264,7 @@ if [[ ! -r "${CONFIG}" ]]; then
fi fi
# Get GPGDIR from pacman.conf iff not specified on command line # Get GPGDIR from pacman.conf iff not specified on command line
if [[ -z PACMAN_KEYRING_DIR && GPGDIR=$(get_from "$CONFIG" "GPGDir") == 0 ]]; then if [[ -z PACMAN_KEYRING_DIR && GPGDIR="$(get_from "$CONFIG" "GPGDir")" == 0 ]]; then
PACMAN_KEYRING_DIR="${GPGDIR}" PACMAN_KEYRING_DIR="${GPGDIR}"
fi fi
PACMAN_KEYRING_DIR=${PACMAN_KEYRING_DIR:-@sysconfdir@/pacman.d/gnupg} PACMAN_KEYRING_DIR=${PACMAN_KEYRING_DIR:-@sysconfdir@/pacman.d/gnupg}