bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pmtest: send valgrind output to var/log/valgrind

Browse source 
This will allow us to detect whether valgrind found any errors while
still preserving pacman's return code for tests.

Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Andrew Gregory 2014-01-06 15:19:31 -05:00 • committed by Allan McRae
parent deaed047fd
commit 19b3ee6d39
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
test/pacman/pmtest.py
View file

@ -220,6 +220,7 @@ class pmtest(object):
cmd.extend(["libtool", "execute", "valgrind", "-q", cmd.extend(["libtool", "execute", "valgrind", "-q",
"--tool=memcheck", "--leak-check=full", "--tool=memcheck", "--leak-check=full",
"--show-reachable=yes", "--show-reachable=yes",
"--log-file=%s" % os.path.join(self.root, "var/log/valgrind"),
"--suppressions=%s" % suppfile]) "--suppressions=%s" % suppfile])
cmd.extend([pacman["bin"], cmd.extend([pacman["bin"],
"--config", os.path.join(self.root, util.PACCONF), "--config", os.path.join(self.root, util.PACCONF),
@ -231,7 +232,7 @@ class pmtest(object):
if pacman["debug"]: if pacman["debug"]:
cmd.append("--debug=%s" % pacman["debug"]) cmd.append("--debug=%s" % pacman["debug"])
cmd.extend(shlex.split(self.args)) cmd.extend(shlex.split(self.args))
if not (pacman["gdb"] or pacman["valgrind"] or pacman["nolog"]): if not (pacman["gdb"] or pacman["nolog"]):
output = open(os.path.join(self.root, util.LOGFILE), 'w') output = open(os.path.join(self.root, util.LOGFILE), 'w')
else: else:
output = None output = None