bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make db->treename a pointer

Browse source 
I really don't think we need statically allocated strings here.

Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Dan McGee 2008-03-26 20:19:44 -05:00
parent 5f1ccdbc27
commit 1dfd841e40
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/libalpm/db.c
View file

@ -439,8 +439,7 @@ pmdb_t *_alpm_db_new(const char *dbpath, const char *treename)
CALLOC(db->path, 1, pathsize, RET_ERR(PM_ERR_MEMORY, NULL)); CALLOC(db->path, 1, pathsize, RET_ERR(PM_ERR_MEMORY, NULL));
sprintf(db->path, "%s%s/", dbpath, treename); sprintf(db->path, "%s%s/", dbpath, treename);
STRDUP(db->treename, treename, RET_ERR(PM_ERR_MEMORY, NULL));
strncpy(db->treename, treename, PATH_MAX);
return(db); return(db);
} }
@ -454,6 +453,7 @@ void _alpm_db_free(pmdb_t *db)
/* cleanup server list */ /* cleanup server list */
FREELIST(db->servers); FREELIST(db->servers);
FREE(db->path); FREE(db->path);
FREE(db->treename);
FREE(db); FREE(db);
return; return;

2
lib/libalpm/db.h
View file

@ -40,7 +40,7 @@ typedef enum _pmdbinfrq_t {
/* Database */ /* Database */
struct __pmdb_t { struct __pmdb_t {
char *path; char *path;
char treename[PATH_MAX]; char *treename;
void *handle; void *handle;
alpm_list_t *pkgcache; alpm_list_t *pkgcache;
alpm_list_t *grpcache; alpm_list_t *grpcache;