bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not refer to FlySpray numbers

Browse source 
These references to bug numbers assume we will forever be using that bug
tracker. It is better to properly comment the code instead (which was
done in almost all cases anyway).

Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Allan McRae 2013-07-15 14:14:46 +10:00
parent c02b16c4cc
commit 247b9af02b
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/libalpm/add.c
View file

@ -530,7 +530,7 @@ static int commit_single_pkg(alpm_handle_t *handle, alpm_pkg_t *newpkg,
} }
/* prepare directory for database entries so permission are correct after /* prepare directory for database entries so permission are correct after
changelog/install script installation (FS#12263) */ changelog/install script installation */
if(_alpm_local_db_prepare(db, newpkg)) { if(_alpm_local_db_prepare(db, newpkg)) {
alpm_logaction(handle, ALPM_CALLER_PREFIX, alpm_logaction(handle, ALPM_CALLER_PREFIX,
"error: could not create database entry %s-%s\n", "error: could not create database entry %s-%s\n",

2
lib/libalpm/dload.c
View file

@ -466,7 +466,7 @@ static int curl_download_internal(struct dload_payload *payload,
/* disconnect relationships from the curl handle for things that might go out /* disconnect relationships from the curl handle for things that might go out
* of scope, but could still be touched on connection teardown. This really * of scope, but could still be touched on connection teardown. This really
* only applies to FTP transfers. See FS#26327 for an example. */ * only applies to FTP transfers. */
curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 1L); curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 1L);
curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, (char *)NULL); curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, (char *)NULL);

2
scripts/makepkg.sh.in
View file

@ -389,7 +389,7 @@ download_file() {
extract_file() { extract_file() {
local file=$1 local file=$1
# fix flyspray #6246 # do not rely on extension for file type
local file_type=$(file -bizL "$file") local file_type=$(file -bizL "$file")
local ext=${file##*.} local ext=${file##*.}
local cmd='' local cmd=''

2
src/pacman/sync.c
View file

@ -648,7 +648,7 @@ static int process_targname(alpm_list_t *dblist, const char *targname,
{ {
alpm_pkg_t *pkg = alpm_find_dbs_satisfier(config->handle, dblist, targname); alpm_pkg_t *pkg = alpm_find_dbs_satisfier(config->handle, dblist, targname);
/* #FS#23342 - skip ignored packages when user says no */ /* skip ignored packages when user says no */
if(alpm_errno(config->handle) == ALPM_ERR_PKG_IGNORED) { if(alpm_errno(config->handle) == ALPM_ERR_PKG_IGNORED) {
pm_printf(ALPM_LOG_WARNING, _("skipping target: %s\n"), targname); pm_printf(ALPM_LOG_WARNING, _("skipping target: %s\n"), targname);
return 0; return 0;

4
src/pacman/util.c
View file

@ -1094,7 +1094,7 @@ double humanize_size(off_t bytes, const char target_unit, int precision,
*label = labels[index]; *label = labels[index];
} }
/* fix FS#27924 so that it doesn't display negative zeroes */ /* do not display negative zeroes */
if(precision >= 0 && val < 0.0 && if(precision >= 0 && val < 0.0 &&
val > (-0.5 / simple_pow(10, precision))) { val > (-0.5 / simple_pow(10, precision))) {
val = 0.0; val = 0.0;
@ -1531,7 +1531,7 @@ static int question(short preset, const char *format, va_list args)
} }
/* if stdin is piped, response does not get printed out, and as a result /* if stdin is piped, response does not get printed out, and as a result
* a \n is missing, resulting in broken output (FS#27909) */ * a \n is missing, resulting in broken output */
if(!isatty(fd_in)) { if(!isatty(fd_in)) {
fprintf(stream, "%s\n", response); fprintf(stream, "%s\n", response);
} }