bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

create coredump on segfault

Browse source 
Overriding the segfault handler prevents the creation of core dumps by
the default handler, which makes debugging segfaults difficult.

Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Andrew Gregory 2019-06-07 21:12:17 -07:00 • committed by Allan McRae
parent e7156e78b8
commit 4e5254dbf3
1 changed files with 22 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/pacman/sighandler.c
View file

@ -38,6 +38,15 @@ static ssize_t xwrite(int fd, const void *buf, size_t count)
return ret; return ret;
} }
static void _reset_handler(int signum)
{
struct sigaction new_action;
sigemptyset(&new_action.sa_mask);
new_action.sa_handler = SIG_DFL;
new_action.sa_flags = 0;
sigaction(signum, &new_action, NULL);
}
/** Catches thrown signals. Performs necessary cleanup to ensure database is /** Catches thrown signals. Performs necessary cleanup to ensure database is
* in a consistent state. * in a consistent state.
* @param signum the thrown signal * @param signum the thrown signal
@ -76,19 +85,26 @@ void install_soft_interrupt_handler(void)
void remove_soft_interrupt_handler(void) void remove_soft_interrupt_handler(void)
{ {
struct sigaction new_action; _reset_handler(SIGINT);
sigemptyset(&new_action.sa_mask); _reset_handler(SIGHUP);
new_action.sa_handler = SIG_DFL;
new_action.sa_flags = 0;
sigaction(SIGINT, &new_action, NULL);
sigaction(SIGHUP, &new_action, NULL);
} }
static void segv_handler(int signum) static void segv_handler(int signum)
{ {
sigset_t segvset;
const char msg[] = "\nerror: segmentation fault\n" const char msg[] = "\nerror: segmentation fault\n"
"Please submit a full bug report with --debug if appropriate.\n"; "Please submit a full bug report with --debug if appropriate.\n";
xwrite(STDERR_FILENO, msg, sizeof(msg) - 1); xwrite(STDERR_FILENO, msg, sizeof(msg) - 1);
/* restore the default handler */
_reset_handler(signum);
/* unblock SIGSEGV */
sigaddset(&segvset, signum);
sigprocmask(SIG_UNBLOCK, &segvset, NULL);
/* re-raise to trigger a core dump */
raise(signum);
/* raise should immediately abort, but just to make absolutely sure */
_Exit(signum); _Exit(signum);
} }