bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix memleak with new alpm_list_reverse usage

Browse source 
Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Dan McGee 2007-11-11 12:59:45 -06:00
parent 8236be9fd8
commit 53fdae9a19
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/libalpm/remove.c
View file

@ -301,11 +301,12 @@ int _alpm_remove_commit(pmtrans_t *trans, pmdb_t *db)
int filenum = alpm_list_count(files); int filenum = alpm_list_count(files);
double percent = 0.0; double percent = 0.0;
alpm_list_t *newfiles;
_alpm_log(PM_LOG_DEBUG, "removing %d files\n", filenum); _alpm_log(PM_LOG_DEBUG, "removing %d files\n", filenum);
/* iterate through the list backwards, unlinking files */ /* iterate through the list backwards, unlinking files */
files = alpm_list_reverse(files); newfiles = alpm_list_reverse(files);
for(lp = files; lp; lp = alpm_list_next(lp)) { for(lp = newfiles; lp; lp = alpm_list_next(lp)) {
unlink_file(info, lp, trans); unlink_file(info, lp, trans);
/* update progress bar after each file */ /* update progress bar after each file */
@ -315,6 +316,7 @@ int _alpm_remove_commit(pmtrans_t *trans, pmdb_t *db)
(pkg_count - alpm_list_count(targ) + 1)); (pkg_count - alpm_list_count(targ) + 1));
position++; position++;
} }
free(newfiles);
} }
/* set progress to 100% after we finish unlinking files */ /* set progress to 100% after we finish unlinking files */