bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libmakepkg: strip - disguard error messages when copying source files

Browse source 
Parallel processing of file stripping is causing a TOC/TOU race when copying
source files into the debug location resulting in error messages from cp.
While hiding this error is not the ideal solution, it is currently the only
one we have. Given this is a error of our own making, and we understand the
cause and have determined there is zero actual downside to ignoring the
error, we will accept this approach until something better is found.

Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Allan McRae 2024-12-24 22:35:38 +10:00
parent 02b35b9155
commit 5f4c7e3ddc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/libmakepkg/tidy/strip.sh.in
View file

@ -61,7 +61,7 @@ package_source_files() {
dest="${dbgsrc}/${t}" dest="${dbgsrc}/${t}"
mkdir -p "${dest%/*}" mkdir -p "${dest%/*}"
if [[ -f "$file" && ! -f "$dest" ]]; then if [[ -f "$file" && ! -f "$dest" ]]; then
cp -- "$file" "$dest" cp -- "$file" "$dest" 2>/dev/null
fi fi
done < <(source_files "$binary") done < <(source_files "$binary")
} }