bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check for overflow when setting HTTP_USER_AGENT

Browse source 
gcc7 issues a warning about a potential overflow if left unchecked.

Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Andrew Gregory 2017-05-10 18:54:56 -04:00 • committed by Allan McRae
parent a2b776f6c9
commit 63087c31b5
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/pacman/pacman.c
View file

@ -271,10 +271,15 @@ static void setuseragent(void)
{ {
char agent[101]; char agent[101];
struct utsname un; struct utsname un;
int len;
uname(&un); uname(&un);
snprintf(agent, 100, "pacman/%s (%s %s) libalpm/%s", len = snprintf(agent, 100, "pacman/%s (%s %s) libalpm/%s",
PACKAGE_VERSION, un.sysname, un.machine, alpm_version()); PACKAGE_VERSION, un.sysname, un.machine, alpm_version());
if(len >= 100) {
pm_printf(ALPM_LOG_WARNING, _("HTTP_USER_AGENT truncated\n"));
}
setenv("HTTP_USER_AGENT", agent, 0); setenv("HTTP_USER_AGENT", agent, 0);
} }