bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

meson: use hidden symbol visiblity by default

Browse source 
All the required public API is annotated with SYMEXPORT, so we can just
add the meson notation, to hide all the symbols by default.

Thus we no longer spill all the internal API into the global namespace.

This is effectively a regression from the autotools build, which used
hidden and internal for DARWIN and others respectively.

The use of hidden is considered sufficient, considering:
 - internal was introduced with commit 920b0d20 ("Update usage of gcc
   __attribute__ flags"), referencing the GCC manual and potential
   optimisations, although
 - the details about the optimisations or respective benefits are close
   to non-existent,
 - the code/data size of the binaries is identical across hidden and
   internal. While the latter produces slightly larger overall binaries.
 - Internal is not widely supported - missing on Darwin, the CMake build
   system lacks a wrapper (unlike for hidden)
 - Internal is not widely used in projects.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Emil Velikov 2021-01-05 00:48:12 +00:00 • committed by Allan McRae
parent d53ba019f5
commit 67a42b9549
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
meson.build
View file

@ -303,6 +303,7 @@ libcommon = static_library(
'common', 'common',
libcommon_sources, libcommon_sources,
include_directories : includes, include_directories : includes,
gnu_symbol_visibility : 'hidden',
install : false) install : false)
alpm_deps = [crypto_provider, libarchive, libcurl, libintl, gpgme] alpm_deps = [crypto_provider, libarchive, libcurl, libintl, gpgme]
@ -313,6 +314,7 @@ libalpm_a = static_library(
# https://github.com/mesonbuild/meson/issues/3937 # https://github.com/mesonbuild/meson/issues/3937
objects : libcommon.extract_all_objects(), objects : libcommon.extract_all_objects(),
include_directories : includes, include_directories : includes,
gnu_symbol_visibility : 'hidden',
dependencies : alpm_deps) dependencies : alpm_deps)
libalpm = library( libalpm = library(