bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libmakepkg - add wrapper function for objcopy

Browse source 
Using objcopy can result in file permission changes.  We work around this
by using "cat" to copy the temporary output file into the target. Extract
this code into a utility function.

Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Allan McRae 2024-11-27 19:46:48 +10:00
parent a2d029388c
commit 71afd4d88f
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
scripts/libmakepkg/tidy/strip.sh.in
View file

@ -66,6 +66,14 @@ package_source_files() {
done < <(source_files "$binary") done < <(source_files "$binary")
} }
safe_objcopy() {
local binary=$1; shift
local tempfile=$(mktemp "$binary.XXXXXX")
objcopy "$@" "$binary" "$tempfile"
cat "$tempfile" > "$binary"
rm "$tempfile"
}
collect_debug_symbols() { collect_debug_symbols() {
local binary=$1; shift local binary=$1; shift
@ -92,10 +100,7 @@ collect_debug_symbols() {
return return
fi fi
local tempfile=$(mktemp "$binary.XXXXXX") safe_objcopy "$binary" --add-gnu-debuglink="$dbgdir/${binary#/}.debug"
objcopy --add-gnu-debuglink="$dbgdir/${binary#/}.debug" "$binary" "$tempfile"
cat "$tempfile" > "$binary"
rm "$tempfile"
# create any needed hardlinks # create any needed hardlinks
while IFS= read -rd '' file ; do while IFS= read -rd '' file ; do