bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

makepkg: when signing packages, report package filename on failure

Browse source 
In commit c6b04c0465 the signing function
was moved out of fakeroot, and thus out of the create_package loop. This
meant that if package signing failed, it was no longer possible to tell
which package it failed on by checking which package creation is
currently running. Successful signing attempts do not have this problem
as we already printed the name of the signature file.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Eli Schwartz 2018-06-12 10:00:29 -04:00 • committed by Allan McRae
parent 9e960d9d5a
commit 885bbb504a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scripts/libmakepkg/integrity/generate_signature.sh.in
View file

@ -40,7 +40,7 @@ create_signature() {
if (( ! ret )); then if (( ! ret )); then
msg2 "$(gettext "Created signature file %s.")" "${filename##*/}.sig" msg2 "$(gettext "Created signature file %s.")" "${filename##*/}.sig"
else else
warning "$(gettext "Failed to sign package file.")" warning "$(gettext "Failed to sign package file %s.")" "${filename##*/}"
fi fi
return $ret return $ret