bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

find_fileconflicts: rename tmpfiles -> newfiles

Browse source 
The files belong to the new version of a package being installed, they
are not temporary in any way.

Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Andrew Gregory 2016-12-17 10:02:18 -05:00 • committed by Allan McRae
parent b6753eeb7e
commit 9c3bf2988f
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/libalpm/conflict.c
View file

@ -419,7 +419,7 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle,
for(current = 0, i = upgrade; i; i = i->next, current++) { for(current = 0, i = upgrade; i; i = i->next, current++) {
alpm_pkg_t *p1 = i->data; alpm_pkg_t *p1 = i->data;
alpm_list_t *j; alpm_list_t *j;
alpm_list_t *tmpfiles = NULL; alpm_list_t *newfiles = NULL;
alpm_pkg_t *dbpkg; alpm_pkg_t *dbpkg;
int percent = (current * 100) / numtargs; int percent = (current * 100) / numtargs;
@ -483,18 +483,18 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle,
* be freed. */ * be freed. */
if(dbpkg) { if(dbpkg) {
/* older ver of package currently installed */ /* older ver of package currently installed */
tmpfiles = _alpm_filelist_difference(alpm_pkg_get_files(p1), newfiles = _alpm_filelist_difference(alpm_pkg_get_files(p1),
alpm_pkg_get_files(dbpkg)); alpm_pkg_get_files(dbpkg));
} else { } else {
/* no version of package currently installed */ /* no version of package currently installed */
alpm_filelist_t *fl = alpm_pkg_get_files(p1); alpm_filelist_t *fl = alpm_pkg_get_files(p1);
size_t filenum; size_t filenum;
for(filenum = 0; filenum < fl->count; filenum++) { for(filenum = 0; filenum < fl->count; filenum++) {
tmpfiles = alpm_list_add(tmpfiles, fl->files[filenum].name); newfiles = alpm_list_add(newfiles, fl->files[filenum].name);
} }
} }
for(j = tmpfiles; j; j = j->next) { for(j = newfiles; j; j = j->next) {
const char *filestr = j->data; const char *filestr = j->data;
const char *relative_path; const char *relative_path;
alpm_list_t *k; alpm_list_t *k;
@ -667,12 +667,12 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle,
alpm_list_free_inner(conflicts, alpm_list_free_inner(conflicts,
(alpm_list_fn_free) alpm_conflict_free); (alpm_list_fn_free) alpm_conflict_free);
alpm_list_free(conflicts); alpm_list_free(conflicts);
alpm_list_free(tmpfiles); alpm_list_free(newfiles);
return NULL; return NULL;
} }
} }
} }
alpm_list_free(tmpfiles); alpm_list_free(newfiles);
} }
PROGRESS(handle, ALPM_PROGRESS_CONFLICTS_START, "", 100, PROGRESS(handle, ALPM_PROGRESS_CONFLICTS_START, "", 100,
numtargs, current); numtargs, current);