bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dload: dont forget to initialize open_mode

Browse source 
That's a funny one, building with optimization levels (with both gcc and
clang) caused open_mode to always be set to "ab", which worked.

This was spotted both with clang-analyzer, and by Jakob who reported a
segfault as he was using an un-optimized build.

Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Xavier Chantry 2011-04-02 15:53:18 +02:00 • committed by Dan McGee
parent 0e03c0849d
commit a461837835
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/libalpm/dload.c
View file

@ -159,7 +159,8 @@ static int curl_download_internal(const char *url, const char *localpath,
{ {
int ret = -1; int ret = -1;
FILE *localf = NULL; FILE *localf = NULL;
const char *open_mode, *useragent; const char *useragent;
const char *open_mode = "wb";
char *destfile, *tempfile; char *destfile, *tempfile;
char hostname[256]; /* RFC1123 states applications should support this length */ char hostname[256]; /* RFC1123 states applications should support this length */
struct stat st; struct stat st;