bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libalpm: Give -U downloads a random .part name if needed

Browse source 
archweb's download links all ended in /download. This cause all the temp
files to be named download.part. With parallel downloads this results in
multiple downloads to go to the same temp file and breaks the transaction.

Assign random temporary filenames to downloads from URLs that are either
missing a filename, or if the filename does not contain at least three
hyphens (as a well formed package filename does).

While this approach to determining when to use a temporary filename is
not 100% foolproof, it does keep nice looking download progress bar names
when a proper package filename is given. The only downside of not using
temporary files when provided with a filename  with three or more hyphens
is URLs created specifically to bypass temporary filename usage can not
be downloaded in parallel. We probably do not want to download packages
from such URLs anyway.

Fixes FS#71464

Modified-by: Allan McRae (do not use temporary files for realish URLs)
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
morganamilo 2021-07-11 17:28:33 +01:00 • committed by Allan McRae
parent 1c5a56884f
commit c0026caab0
2 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/libalpm/dload.c
View file

@ -767,7 +767,7 @@ static int curl_add_payload(alpm_handle_t *handle, CURLM *curlm,
GOTO_ERR(handle, ALPM_ERR_SERVER_BAD_URL, cleanup); GOTO_ERR(handle, ALPM_ERR_SERVER_BAD_URL, cleanup);
} }
if(payload->remote_name && strlen(payload->remote_name) > 0) { if(!payload->random_partfile && payload->remote_name && strlen(payload->remote_name) > 0) {
if(!payload->destfile_name) { if(!payload->destfile_name) {
payload->destfile_name = get_fullpath(localpath, payload->remote_name, ""); payload->destfile_name = get_fullpath(localpath, payload->remote_name, "");
} }
@ -776,8 +776,9 @@ static int curl_add_payload(alpm_handle_t *handle, CURLM *curlm,
goto cleanup; goto cleanup;
} }
} else { } else {
/* URL doesn't contain a filename, so make a tempfile. We can't support /* We want a random filename or the URL does not contain a filename, so download to a
* resuming this kind of download; partial transfers will be destroyed */ * temporary location. We can not support resuming this kind of download; any partial
* transfers will be destroyed */
payload->unlink_on_fail = 1; payload->unlink_on_fail = 1;
payload->localf = create_tempfile(payload, localpath); payload->localf = create_tempfile(payload, localpath);
@ -986,11 +987,20 @@ int SYMEXPORT alpm_fetch_pkgurl(alpm_handle_t *handle, const alpm_list_t *urls,
alpm_list_append(fetched, filepath); alpm_list_append(fetched, filepath);
} else { } else {
struct dload_payload *payload = NULL; struct dload_payload *payload = NULL;
char *c;
ASSERT(url, GOTO_ERR(handle, ALPM_ERR_WRONG_ARGS, err)); ASSERT(url, GOTO_ERR(handle, ALPM_ERR_WRONG_ARGS, err));
CALLOC(payload, 1, sizeof(*payload), GOTO_ERR(handle, ALPM_ERR_MEMORY, err)); CALLOC(payload, 1, sizeof(*payload), GOTO_ERR(handle, ALPM_ERR_MEMORY, err));
STRDUP(payload->fileurl, url, FREE(payload); GOTO_ERR(handle, ALPM_ERR_MEMORY, err)); STRDUP(payload->fileurl, url, FREE(payload); GOTO_ERR(handle, ALPM_ERR_MEMORY, err));
payload->allow_resume = 1;
c = strrchr(url, '/');
if(strstr(c, ".pkg")) {
/* we probably have a usable package filename to download to */
payload->allow_resume = 1;
} else {
payload->random_partfile = 1;
}
payload->handle = handle; payload->handle = handle;
payload->trust_remote_name = 1; payload->trust_remote_name = 1;
payload->download_signature = (handle->siglevel & ALPM_SIG_PACKAGE); payload->download_signature = (handle->siglevel & ALPM_SIG_PACKAGE);

1
lib/libalpm/dload.h
View file

@ -44,6 +44,7 @@ struct dload_payload {
off_t prevprogress; off_t prevprogress;
int force; int force;
int allow_resume; int allow_resume;
int random_partfile;
int errors_ok; int errors_ok;
int unlink_on_fail; int unlink_on_fail;
int trust_remote_name; int trust_remote_name;