vercmp: fail when the wrong number of arguments are provided

Fixes FS#49093

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
This commit is contained in:
Eli Schwartz 2018-01-14 00:11:08 -05:00 committed by Allan McRae
parent 19dabcc19a
commit d911438352

View file

@ -40,8 +40,6 @@ static void usage(void)
int main(int argc, char *argv[]) int main(int argc, char *argv[])
{ {
const char *s1 = "";
const char *s2 = "";
int ret; int ret;
if(argc == 1) { if(argc == 1) {
@ -53,14 +51,13 @@ int main(int argc, char *argv[])
usage(); usage();
return 0; return 0;
} }
if(argc > 2) { if(argc != 3) {
s2 = argv[2]; fprintf(stderr, "error: %d argument(s) specified\n\n"
} "Usage: vercmp <ver1> <ver2>\n", argc - 1);
if(argc > 1) { return EXIT_FAILURE;
s1 = argv[1];
} }
ret = alpm_pkg_vercmp(s1, s2); ret = alpm_pkg_vercmp(argv[1], argv[2]);
printf("%d\n", ret); printf("%d\n", ret);
return EXIT_SUCCESS; return EXIT_SUCCESS;
} }