bryson/pacman
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix broken output when asking question and stdin is piped

Browse source 
When asking question and stdin is piped, the response does not get printed out,
resulting in a missing \n and broken output (FS#27909); printing the response
fixes it.

Signed-off-by: Olivier Brunel <i.am.jack.mail@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
This commit is contained in:
Olivier Brunel 2012-01-12 16:08:48 +01:00 • committed by Dan McGee
parent 4e60b9646d
commit d9af1a0cf2
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/pacman/util.c
View file

@ -1365,6 +1365,12 @@ static int question(short preset, char *fmt, va_list args)
return preset; return preset;
} }
/* if stdin is piped, response does not get printed out, and as a result
* a \n is missing, resulting in broken output (FS#27909) */
if(!isatty(fileno(stdin))) {
fprintf(stream, "%s\n", response);
}
if(strcasecmp(response, _("Y")) == 0 || strcasecmp(response, _("YES")) == 0) { if(strcasecmp(response, _("Y")) == 0 || strcasecmp(response, _("YES")) == 0) {
return 1; return 1;
} else if(strcasecmp(response, _("N")) == 0 || strcasecmp(response, _("NO")) == 0) { } else if(strcasecmp(response, _("N")) == 0 || strcasecmp(response, _("NO")) == 0) {