From dfee773364b383dfe25ed945176827126b107279 Mon Sep 17 00:00:00 2001 From: Allan McRae Date: Thu, 25 Jan 2024 14:30:59 +1000 Subject: [PATCH] clean_filename: use strdup instead of malloc and memcpy Signed-off-by: Allan McRae --- src/pacman/callback.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 84a587aa..738bc350 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -754,14 +754,11 @@ static void init_total_progressbar(void) static char *clean_filename(const char *filename) { - int len = strlen(filename); char *p; - char *fname = malloc(len + 1); - memcpy(fname, filename, len + 1); + char *fname = strdup(filename); /* strip package or DB extension for cleaner look */ if((p = strstr(fname, ".pkg")) || (p = strstr(fname, ".db")) || (p = strstr(fname, ".files"))) { - len = p - fname; - fname[len] = '\0'; + fname[p - fname] = '\0'; } return fname;