0bf4779cda
Extracting function variables containing arbitrarily scoped variables of
arbitrary nature is a disaster, but let's at least cover the common case
of using the actual '$pkgname' in an install/changelog file. It's the
odd case of actually being basically justified use of disambiguating
between the same variable used in multiple different split packages...
and also, --printsrcinfo already uses and overwrites the variable
'pkgname' in pkgbuild_extract_to_srcinfo, so this "works" in .SRCINFO
but doesn't work in .src.tar.gz
It doesn't work in lint_pkgbuild either, but in that case the problem is
being too permissive, not too restrictive -- we might end up checking
the same file twice, and printing that it is missing twice.
Fixes FS#64932
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
(cherry picked from commit d626a17ef9)
51 lines
1.6 KiB
Bash
51 lines
1.6 KiB
Bash
#!/bin/bash
|
|
#
|
|
# changelog.sh - Check the files in the 'changelog' array exist.
|
|
#
|
|
# Copyright (c) 2014-2019 Pacman Development Team <pacman-dev@archlinux.org>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
[[ -n "$LIBMAKEPKG_LINT_PKGBUILD_CHANGELOG_SH" ]] && return
|
|
LIBMAKEPKG_LINT_PKGBUILD_CHANGELOG_SH=1
|
|
|
|
LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
|
|
|
|
source "$LIBRARY/util/message.sh"
|
|
source "$LIBRARY/util/pkgbuild.sh"
|
|
source "$LIBRARY/lint_pkgbuild/util.sh"
|
|
|
|
|
|
lint_pkgbuild_functions+=('lint_changelog')
|
|
|
|
|
|
lint_changelog() {
|
|
local file changelog_list
|
|
|
|
changelog_list=("${changelog[@]}")
|
|
# set pkgname the same way we do for running package(), this way we get
|
|
# the right value in extract_function_variable
|
|
local pkgname_backup=(${pkgname[@]})
|
|
local pkgname
|
|
for pkgname in "${pkgname_backup[@]}"; do
|
|
if extract_function_variable "package_$pkgname" changelog 0 file; then
|
|
changelog_list+=("$file")
|
|
fi
|
|
done
|
|
|
|
check_files_exist 'changelog' "${changelog_list[@]}" || ret=1
|
|
|
|
return $ret
|
|
}
|