18e49f2c97
During a package build we call prepare_buildenv in multiple stages of the process. For debug packages, one of the hooks is buildenv_debugflags which populates the debug flags to the according variables. The issue is that the behavior of the current implementation of buildenv_debugflags is not idempotent, so consecutive calls will append the same flags again. In certain cases this isn't an issue, however for context aware build frontends like cargo any change of the build inputs leads to a fresh build. This means that any invocation of such a build ecosystem inside the package() function will trigger a full rebuild, which is not desired. To fix this issue, this commit makes buildenv_debugflags idempotent by only appending flags once to the target variables. Signed-off-by: Levente Polyak <anthraxx@archlinux.org>
124 lines
2.8 KiB
Bash
124 lines
2.8 KiB
Bash
#!/bin/bash
|
|
#
|
|
# util.sh - general utility functions
|
|
#
|
|
# Copyright (c) 2006-2022 Pacman Development Team <pacman-dev@lists.archlinux.org>
|
|
# Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
[[ -n "$LIBMAKEPKG_UTIL_UTIL_SH" ]] && return
|
|
LIBMAKEPKG_UTIL_UTIL_SH=1
|
|
|
|
MAKEPKG_LIBRARY=${MAKEPKG_LIBRARY:-'@libmakepkgdir@'}
|
|
|
|
source "$MAKEPKG_LIBRARY/util/error.sh"
|
|
source "$MAKEPKG_LIBRARY/util/message.sh"
|
|
|
|
##
|
|
# usage : in_array( $needle, $haystack )
|
|
# return : 0 - found
|
|
# 1 - not found
|
|
##
|
|
in_array() {
|
|
local needle=$1; shift
|
|
local item
|
|
for item in "$@"; do
|
|
[[ $item = "$needle" ]] && return 0 # Found
|
|
done
|
|
return 1 # Not Found
|
|
}
|
|
|
|
# tests if a variable is an array
|
|
is_array() {
|
|
local v=$1
|
|
local ret=1
|
|
|
|
if [[ ${!v@a} = *a* ]]; then
|
|
ret=0
|
|
fi
|
|
|
|
return $ret
|
|
}
|
|
|
|
# Canonicalize a directory path if it exists
|
|
canonicalize_path() {
|
|
local path="$1"
|
|
|
|
if [[ -d $path ]]; then
|
|
(
|
|
cd_safe "$path"
|
|
pwd -P
|
|
)
|
|
else
|
|
printf "%s\n" "$path"
|
|
fi
|
|
}
|
|
|
|
dir_is_empty() {
|
|
(
|
|
shopt -s dotglob nullglob
|
|
files=("$1"/*)
|
|
(( ${#files} == 0 ))
|
|
)
|
|
}
|
|
|
|
cd_safe() {
|
|
if ! cd "$1"; then
|
|
error "$(gettext "Failed to change to directory %s")" "$1"
|
|
plainerr "$(gettext "Aborting...")"
|
|
exit 1
|
|
fi
|
|
}
|
|
|
|
# Try to create directory if one does not yet exist. Fails if the directory
|
|
# exists but has no write permissions, or if there is an existing file with
|
|
# the same name.
|
|
ensure_writable_dir() {
|
|
local dirtype="$1" dirpath="$2"
|
|
|
|
if ! mkdir -p "$dirpath" 2>/dev/null; then
|
|
error "$(gettext "Failed to create the directory \$%s (%s).")" "$dirtype" "$dirpath"
|
|
return 1
|
|
elif [[ ! -w $dirpath ]]; then
|
|
error "$(gettext "You do not have write permission for the directory \$%s (%s).")" "$dirtype" "$dirpath"
|
|
return 1
|
|
fi
|
|
|
|
return 0
|
|
}
|
|
|
|
# source a file and fail if it does not succeed
|
|
source_safe() {
|
|
local shellopts=$(shopt -p extglob)
|
|
shopt -u extglob
|
|
|
|
if ! source "$@"; then
|
|
error "$(gettext "Failed to source %s")" "$1"
|
|
exit $E_MISSING_FILE
|
|
fi
|
|
|
|
eval "$shellopts"
|
|
}
|
|
|
|
# Append a string to a variable if the value is not already contained.
|
|
# usage : append_once( $ref, $value )
|
|
append_once() {
|
|
local -n var=$1
|
|
local value=$2
|
|
if [[ ! $var =~ (^| )"$value"($| ) ]]; then
|
|
var+=" $value"
|
|
fi
|
|
}
|