2c94118dc1
In commit 91b72cc386 support was added for
linting depends/etc. to ensure they contain only valid dependency
specifiers. However it did not properly take into account the
possibility of dependencies linked to a specific pkgrel or epoch, which
promptly failed to build because "-" and ":" is not allowed in a pkgver.
pkgrel is something supported by pacman and useful for e.g. split packages
which cannot be mismatched even if the pkgver is the same. Fix by
removing an optional suffixed "-$decimal" when checking for a valid
pkgver.
epoch is kind of difficult to do without :D so likewise fix by removing
an optional prefixed "$integer:"
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Allan McRae <allan@archlinux.org>
58 lines
1.8 KiB
Bash
58 lines
1.8 KiB
Bash
#!/bin/bash
|
|
#
|
|
# conflicts.sh - Check the 'conflicts' array conforms to requirements.
|
|
#
|
|
# Copyright (c) 2014-2018 Pacman Development Team <pacman-dev@archlinux.org>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
[[ -n "$LIBMAKEPKG_LINT_PKGBUILD_CONFLICTS_SH" ]] && return
|
|
LIBMAKEPKG_LINT_PKGBUILD_CONFLICTS_SH=1
|
|
|
|
LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
|
|
|
|
source "$LIBRARY/lint_pkgbuild/pkgname.sh"
|
|
source "$LIBRARY/lint_pkgbuild/pkgver.sh"
|
|
source "$LIBRARY/util/message.sh"
|
|
source "$LIBRARY/util/pkgbuild.sh"
|
|
|
|
|
|
lint_pkgbuild_functions+=('lint_conflicts')
|
|
|
|
|
|
lint_conflicts() {
|
|
local conflicts_list conflict name ver ret=0
|
|
|
|
get_pkgbuild_all_split_attributes conflicts conflicts_list
|
|
|
|
# save our shell options and turn on extglob
|
|
local shellopts=$(shopt -p)
|
|
shopt -s extglob
|
|
|
|
for conflict in "${conflicts_list[@]}"; do
|
|
name=${conflict%%@(<|>|=|>=|<=)*}
|
|
# remove optional epoch in version specifier
|
|
ver=${conflict##$name@(<|>|=|>=|<=)?(+([0-9]):)}
|
|
lint_one_pkgname conflicts "$name" || ret=1
|
|
if [[ $ver != $conflict ]]; then
|
|
# remove optional pkgrel in version specifier
|
|
check_pkgver "${ver%-+([0-9])?(.+([0-9]))}" conflicts || ret=1
|
|
fi
|
|
done
|
|
|
|
eval "$shellopts"
|
|
|
|
return $ret
|
|
}
|