91b72cc386
depends, provides, conflicts, replaces, and other variables that are meant to contain package names, are now checked to ensure 1) the name component contains only characters that would equate to a valid pkgname. 2) the version component contains only characters that would equate to a valid pkgver. 3) comparison operator is a valid comparison operator (e.g. provides only allows exact = while optdepends doesn't allow anything) This also refactors pkgname into a shared utility function, wires up pkgbase optdepends and provides to use it, and gives pkgver a touchup to allow referencing where it was called from. Fixes FS#57833 and a bit of extra. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org>
56 lines
1.6 KiB
Bash
56 lines
1.6 KiB
Bash
#!/bin/bash
|
|
#
|
|
# depends.sh - Check the 'depends' array conforms to requirements.
|
|
#
|
|
# Copyright (c) 2014-2018 Pacman Development Team <pacman-dev@archlinux.org>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
[[ -n "$LIBMAKEPKG_LINT_PKGBUILD_DEPENDS_SH" ]] && return
|
|
LIBMAKEPKG_LINT_PKGBUILD_DEPENDS_SH=1
|
|
|
|
LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
|
|
|
|
source "$LIBRARY/lint_pkgbuild/pkgname.sh"
|
|
source "$LIBRARY/lint_pkgbuild/pkgver.sh"
|
|
source "$LIBRARY/util/message.sh"
|
|
source "$LIBRARY/util/pkgbuild.sh"
|
|
|
|
|
|
lint_pkgbuild_functions+=('lint_depends')
|
|
|
|
|
|
lint_depends() {
|
|
local depends_list depend name ver ret=0
|
|
|
|
get_pkgbuild_all_split_attributes depends depends_list
|
|
|
|
# save our shell options and turn on extglob
|
|
local shellopts=$(shopt -p)
|
|
shopt -s extglob
|
|
|
|
for depend in "${depends_list[@]}"; do
|
|
name=${depend%%@(<|>|=|>=|<=)*}
|
|
ver=${depend#*@(<|>|=|>=|<=)}
|
|
lint_one_pkgname depends "$name" || ret=1
|
|
if [[ $ver != $depend ]]; then
|
|
check_pkgver "$ver" depends || ret=1
|
|
fi
|
|
done
|
|
|
|
eval "$shellopts"
|
|
|
|
return $ret
|
|
}
|