b93dfa935f
The right-hand side of the [[ ... = ... ]] keyword is an exception to the general rule that quoting is unnecessary with [[ This is usually not a problem, e.g. in libmakepkg, lint_one_pkgname will already fail if pkgname has an asterisk, but it certainly doesn't hurt to be "more proper" and go with the spec; it is more dangerous in repo-add, which can get caught in an infinite loop instead of safely asserting there is no package named 'foo*'. Reported-by: Rafael Ascensão <rafa.almas@gmail.com> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org>
54 lines
1.7 KiB
Bash
54 lines
1.7 KiB
Bash
#!/bin/bash
|
|
#
|
|
# optdepends.sh - Check the 'optdepends' array conforms to requirements.
|
|
#
|
|
# Copyright (c) 2014-2018 Pacman Development Team <pacman-dev@archlinux.org>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
[[ -n "$LIBMAKEPKG_LINT_PKGBUILD_OPTDEPENDS_SH" ]] && return
|
|
LIBMAKEPKG_LINT_PKGBUILD_OPTDEPENDS_SH=1
|
|
|
|
LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
|
|
|
|
source "$LIBRARY/lint_pkgbuild/fullpkgver.sh"
|
|
source "$LIBRARY/lint_pkgbuild/pkgname.sh"
|
|
source "$LIBRARY/util/message.sh"
|
|
source "$LIBRARY/util/pkgbuild.sh"
|
|
|
|
|
|
lint_pkgbuild_functions+=('lint_optdepends')
|
|
|
|
|
|
lint_optdepends() {
|
|
local optdepends_list optdepend name ver ret=0
|
|
|
|
get_pkgbuild_all_split_attributes optdepends optdepends_list
|
|
|
|
# this function requires extglob - save current status to restore later
|
|
local shellopts=$(shopt -p extglob)
|
|
shopt -s extglob
|
|
|
|
for optdepend in "${optdepends_list[@]%%:[[:space:]]*}"; do
|
|
name=${optdepend%%@(<|>|=|>=|<=)*}
|
|
lint_one_pkgname optdepends "$name" || ret=1
|
|
if [[ $name != "$optdepend" ]]; then
|
|
ver=${optdepend##$name@(<|>|=|>=|<=)}
|
|
check_fullpkgver "$ver" optdepends || ret=1
|
|
fi
|
|
done
|
|
|
|
return $ret
|
|
}
|